Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove files causing file checks to fail after updating Matomo #18472

Closed
justinvelluppillai opened this issue Dec 9, 2021 · 0 comments · Fixed by #18473
Closed

Remove files causing file checks to fail after updating Matomo #18472

justinvelluppillai opened this issue Dec 9, 2021 · 0 comments · Fixed by #18473
Assignees
@sgiehl
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.6.2

Comments

@justinvelluppillai
Copy link
Contributor

justinvelluppillai commented Dec 9, 2021 •
edited

Matomo 4.6.0, 4.6.1, 4.6.2-RC1 leave a few files behind that then cause the system check to show these Files to Delete:

File to delete: misc/composer/build-xhprof.sh
File to delete: misc/composer/clean-xhprof.sh
File to delete: node_modules/iframe-resizer/.eslintrc
File to delete: node_modules/jquery.dotdotdot/.npmignore
File to delete: node_modules/ng-dialog/.eslintrc

This issue should be merged to next_release branch for Matomo 4.6.2.

Expected Behavior

There should be no files to delete after an update if there were none before.

Current Behavior

There are files to delete after an update

Possible Solution

Create an updater script to delete those 5 files

Steps to Reproduce (for Bugs)

  1. Install Matomo 4.5.0
  2. Update to Matomo 4.6.2-RC1
  3. View System Checks and you will see the above files to delete.

Your Environment

  • Matomo Version:
  • PHP Version:
  • Server Operating System:
  • Additionally installed plugins:
  • Browser:
  • Operating System:
@justinvelluppillai justinvelluppillai added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Dec 9, 2021
@justinvelluppillai justinvelluppillai added this to the 4.6.2 milestone Dec 9, 2021
@sgiehl sgiehl self-assigned this Dec 9, 2021
@sgiehl sgiehl added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Dec 9, 2021
@sgiehl sgiehl mentioned this issue Dec 9, 2021
Merged
11 tasks
@sgiehl sgiehl linked a pull request Dec 9, 2021 that will close this issue
Ensure update to 4.6.2 removes some files #18473
Merged
11 tasks
@sgiehl sgiehl closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.6.2
Development

Successfully merging a pull request may close this issue.

Ensure update to 4.6.2 removes some files matomo-org/matomo
2 participants
@justinvelluppillai @sgiehl