@heurteph-ei opened this Issue on December 8th 2021

Expected Behavior

No warning

Current Behavior

After the migration to version 4.6.1, some warnings are displayed in each page of the Matomo UI:

WARNING: /core/DataTable/Row.php(805): Trying to add two strings in DataTable\Row::sumRowArray: 2021-12-07 01:50:26 + 2021-12-07 02:05:12 for column _metadata in row # [‘label’ => ‘Martijn’, ‘nb_visits’ => 73, ‘nb_actions’ => 82, ‘Actions_nb_pageviews’ => 79, ‘Goal_revenue’ => 0, ‘Goal_nb_conversions’ => 0, ‘_metadata’ => array ( ‘ts_archived’ => ‘2021-12-07 01:50:26’, ), ‘visits_evolution’ => 2.076, ‘visits_evolution_trend’ => 1, ‘actions_evolution’ => 1.504, ‘actions_evolution_trend’ => 1, ‘pageviews_evolution’ (Module: MultiSites, Action: getAllWithGroups, In CLI mode: false)

Steps to Reproduce (for Bugs)

Migration from version 4.5.0 to version 4.6.1...
Then open Matomo Analytics...

Context

From Forum:
https://forum.matomo.org/t/error-after-update-to-4-6-1/43990

Your Environment

  • Matomo new Version: 4.6.1
  • Matomo previous Version: 4.5.0
  • PHP Version: To be completed
  • Server Operating System: To be completed
  • Additionally installed plugins: To be completed
@heurteph-ei commented on December 9th 2021

Some screen prints:

@sgiehl commented on December 9th 2021 Member

@heurteph-ei Are you able to say which request fails on the dashboard? Should be visible in the browser console.

@tsteur commented on December 9th 2021 Member

FYI I would assume that the request itself maybe works but on a next page view these warnings show up? and the failed request is a different issue?

@heurteph-ei commented on December 10th 2021




@heurteph-ei commented on December 10th 2021

The user says also

If I press reload browser the messages will be gone!, so next time I will copy the HTTP request error

@sgiehl commented on December 15th 2021 Member

@heurteph-ei This should be fixed with the next release. As we weren't able to reproduce that, feel free to reopen the issue or create a new one, if that still happens with the next release.

@twixi commented on December 18th 2021

i have too error 4.6.2 and
WARNING: /core/DataTable/Row.php(805): Trying to add two strings in DataTable\Row::sumRowArray: 2021-12-18 12:41:58 + 2021-12-18 12:42:02 for column _metadata in row # ['label' => 'EG', 'nb_visits' => 65, 'nb_actions' => 133, 'Actions_nb_pageviews' => 110, 'Goal_revenue' => 0, 'Goal_nb_conversions' => 0, '_metadata' => array ( 'ts_archived' => '2021-12-18 12:41:58', ), 'visits_evolution' => -0.692, 'visits_evolution_trend' => -1, 'actions_evolution' => -0.835, 'actions_evolution_trend' => -1, 'pageviews_evolution' (Module: MultiSites, Action: getAllWithGroups, In CLI mode: false)

WARNING: /core/DataTable/Row.php(805): Trying to add two strings in DataTable\Row::sumRowArray: 0 + 2021-12-18 12:42:07 for column _metadata in row # ['label' => 'EG', 'nb_visits' => 70, 'nb_actions' => 142, 'Actions_nb_pageviews' => 119, 'Goal_revenue' => 0, 'Goal_nb_conversions' => 0, '_metadata' => array ( 'ts_archived' => 0, ), 'visits_evolution' => -1.04, 'visits_evolution_trend' => -2, 'actions_evolution' => -1.219, 'actions_evolution_trend' => -2, 'pageviews_evolution' => -1.255, 'pageviews_evolution_trend' (Module: MultiSites, Action: getAllWithGroups, In CLI mode: false)
and data not show...

Зображення без підпису

@Findus23 commented on December 18th 2021 Member

@twixi Can you try applying the change from #18500 to see if it fixes it for you?

@twixi commented on December 18th 2021

I do not understand what needs to be done.... in #18500

@Sir-Will commented on January 10th 2022 Contributor

I'm still getting this error after the change from #18500.


WARNING: /core/DataTable/Row.php(806): Trying to add two strings in DataTable\Row::sumRowArray: 2022-01-10 00:06:28 + 2022-01-10 00:05:06 for column _metadata in row # ['label' => 'gaming', 'nb_visits' => 14459, 'nb_actions' => 63012, 'Actions_nb_pageviews' => 26368, 'Goal_revenue' => 0, 'Goal_nb_conversions' => 0, '_metadata' => array ( 'ts_archived' => '2022-01-10 00:06:28', ), 'visits_evolution' => 0.049, 'visits_evolution_trend' => 1, 'actions_evolution' => 0.02, 'actions_evolution_trend' => 1, 'pageviews_evol (Module: MultiSites, Action: getAllWithGroups, In CLI mode: false)
@tsteur commented on January 10th 2022 Member

@bx80 could there maybe be still an issue?

@bx80 commented on January 10th 2022 Contributor

Thanks to everyone following up on this issue, it looks like the fix in #18500 didn't work.

This is probably because unsummable columns are only checked for top level column names, if the column is an array (as it is in this case _metadata) then the array keys are not checked against the unsummable columns, so an attempt to sum up ts_archived is still being made even though it is meant to be ignored.

I will create another PR to also check array keys against the unsummable columns list when summing row data, which should hopefully resolve this warning message.

This Issue was closed on December 15th 2021
Powered by GitHub Issue Mirror