Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING: /core/DataTable/Row.php(805) after update to 4.6.1 #18468

Closed
heurteph-ei opened this issue Dec 8, 2021 · 12 comments · Fixed by #18500 or #18600
Closed

WARNING: /core/DataTable/Row.php(805) after update to 4.6.1 #18468

heurteph-ei opened this issue Dec 8, 2021 · 12 comments · Fixed by #18500 or #18600
Assignees
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@heurteph-ei
Copy link

Expected Behavior

No warning

Current Behavior

After the migration to version 4.6.1, some warnings are displayed in each page of the Matomo UI:

WARNING: /core/DataTable/Row.php(805): Trying to add two strings in DataTable\Row::sumRowArray: 2021-12-07 01:50:26 + 2021-12-07 02:05:12 for column _metadata in row # [‘label’ => ‘Martijn’, ‘nb_visits’ => 73, ‘nb_actions’ => 82, ‘Actions_nb_pageviews’ => 79, ‘Goal_revenue’ => 0, ‘Goal_nb_conversions’ => 0, ‘_metadata’ => array ( ‘ts_archived’ => ‘2021-12-07 01:50:26’, ), ‘visits_evolution’ => 2.076, ‘visits_evolution_trend’ => 1, ‘actions_evolution’ => 1.504, ‘actions_evolution_trend’ => 1, ‘pageviews_evolution’ (Module: MultiSites, Action: getAllWithGroups, In CLI mode: false)

Steps to Reproduce (for Bugs)

Migration from version 4.5.0 to version 4.6.1...
Then open Matomo Analytics...

Context

From Forum:
https://forum.matomo.org/t/error-after-update-to-4-6-1/43990

Your Environment

  • Matomo new Version: 4.6.1
  • Matomo previous Version: 4.5.0
  • PHP Version: To be completed
  • Server Operating System: To be completed
  • Additionally installed plugins: To be completed
@heurteph-ei heurteph-ei added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Dec 8, 2021
@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 8, 2021
@tsteur tsteur added this to the 4.7.0 milestone Dec 8, 2021
@heurteph-ei
Copy link
Author

Some screen prints:

@sgiehl
Copy link
Member

sgiehl commented Dec 9, 2021

@heurteph-ei Are you able to say which request fails on the dashboard? Should be visible in the browser console.

@tsteur
Copy link
Member

tsteur commented Dec 9, 2021

FYI I would assume that the request itself maybe works but on a next page view these warnings show up? and the failed request is a different issue?

@heurteph-ei
Copy link
Author

heurteph-ei commented Dec 10, 2021




@heurteph-ei
Copy link
Author

The user says also

If I press reload browser the messages will be gone!, so next time I will copy the HTTP request error

@bx80 bx80 self-assigned this Dec 13, 2021
@sgiehl
Copy link
Member

sgiehl commented Dec 15, 2021

@heurteph-ei This should be fixed with the next release. As we weren't able to reproduce that, feel free to reopen the issue or create a new one, if that still happens with the next release.

@twixi
Copy link

twixi commented Dec 18, 2021

i have too error 4.6.2 and
WARNING: /core/DataTable/Row.php(805): Trying to add two strings in DataTable\Row::sumRowArray: 2021-12-18 12:41:58 + 2021-12-18 12:42:02 for column _metadata in row # ['label' => 'EG', 'nb_visits' => 65, 'nb_actions' => 133, 'Actions_nb_pageviews' => 110, 'Goal_revenue' => 0, 'Goal_nb_conversions' => 0, '_metadata' => array ( 'ts_archived' => '2021-12-18 12:41:58', ), 'visits_evolution' => -0.692, 'visits_evolution_trend' => -1, 'actions_evolution' => -0.835, 'actions_evolution_trend' => -1, 'pageviews_evolution' (Module: MultiSites, Action: getAllWithGroups, In CLI mode: false)

WARNING: /core/DataTable/Row.php(805): Trying to add two strings in DataTable\Row::sumRowArray: 0 + 2021-12-18 12:42:07 for column _metadata in row # ['label' => 'EG', 'nb_visits' => 70, 'nb_actions' => 142, 'Actions_nb_pageviews' => 119, 'Goal_revenue' => 0, 'Goal_nb_conversions' => 0, '_metadata' => array ( 'ts_archived' => 0, ), 'visits_evolution' => -1.04, 'visits_evolution_trend' => -2, 'actions_evolution' => -1.219, 'actions_evolution_trend' => -2, 'pageviews_evolution' => -1.255, 'pageviews_evolution_trend' (Module: MultiSites, Action: getAllWithGroups, In CLI mode: false)
and data not show...

Зображення без підпису

@Findus23
Copy link
Member

@twixi Can you try applying the change from #18500 to see if it fixes it for you?

@twixi
Copy link

twixi commented Dec 18, 2021

I do not understand what needs to be done.... in #18500

@Sir-Will
Copy link
Contributor

I'm still getting this error after the change from #18500.

WARNING: /core/DataTable/Row.php(806): Trying to add two strings in DataTable\Row::sumRowArray: 2022-01-10 00:06:28 + 2022-01-10 00:05:06 for column _metadata in row # ['label' => 'gaming', 'nb_visits' => 14459, 'nb_actions' => 63012, 'Actions_nb_pageviews' => 26368, 'Goal_revenue' => 0, 'Goal_nb_conversions' => 0, '_metadata' => array ( 'ts_archived' => '2022-01-10 00:06:28', ), 'visits_evolution' => 0.049, 'visits_evolution_trend' => 1, 'actions_evolution' => 0.02, 'actions_evolution_trend' => 1, 'pageviews_evol (Module: MultiSites, Action: getAllWithGroups, In CLI mode: false)

@tsteur
Copy link
Member

tsteur commented Jan 10, 2022

@bx80 could there maybe be still an issue?

@bx80
Copy link
Contributor

bx80 commented Jan 10, 2022

Thanks to everyone following up on this issue, it looks like the fix in #18500 didn't work.

This is probably because unsummable columns are only checked for top level column names, if the column is an array (as it is in this case _metadata) then the array keys are not checked against the unsummable columns, so an attempt to sum up ts_archived is still being made even though it is meant to be ignored.

I will create another PR to also check array keys against the unsummable columns list when summing row data, which should hopefully resolve this warning message.

@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
8 participants