[Vue] fix url location updating regression in MatomoUrl.updateLocation use #18449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
Needs Review
diosmosis
force-pushed
the
vue-period-selector-regression
branch
from
00529d2
to
90ef0e8
Compare
sgiehl
approved these changes
Dec 7, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To reproduce the issue on 4.x-dev, either change the period in the period selector (eg, select a month from a day) or try to compare a segment. There are some URL params that cannot appear in the hash, eg
module/action, so the base set of parameters when changing the URL has to be determined carefully.Review