Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also try to remove hidden files on update #18447

Merged
merged 1 commit into from Dec 5, 2021
Merged

Also try to remove hidden files on update #18447

merged 1 commit into from Dec 5, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 3, 2021

Description:

Hidden files were not removed correctly on update. The reason is the glob we are using to create a diff for the directories.

refs #18435

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 3, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Dec 3, 2021
@justinvelluppillai justinvelluppillai merged commit deebc02 into 4.x-dev Dec 5, 2021
@justinvelluppillai justinvelluppillai deleted the m-18435 branch December 5, 2021 21:43
@sgiehl sgiehl mentioned this pull request Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @justinvelluppillai