@diosmosis opened this Pull Request on December 3rd 2021 Member

Description:

This PR depends on #18443.

Changes:

  • The current popover handler directive which if placed on a page handles the popover parameter has been replaced with a service class that does the same thing but doesn't need any HTML placed on the page.

image

Review

@diosmosis commented on December 6th 2021 Member

UI tests should be passing for this one

@peterhashair commented on December 12th 2021 Contributor

maybe we need to resolve the conflicts, I am trying to fix those local, but it seems to return a blank page without any javascript errors on my tests.

@github-actions[bot] commented on December 20th 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

This Pull Request was closed on January 1st 2022
Powered by GitHub Issue Mirror