Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] migrate ajax-form directive to vue #18443

Merged
merged 554 commits into from Dec 31, 2021
Merged

[Vue] migrate ajax-form directive to vue #18443

merged 554 commits into from Dec 31, 2021

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Dec 3, 2021 •
edited

Description:

This PR is based off of #18442.

  • Migrate piwik-ajax-form directive to a vue component. Since this directive shared the scope w/ the transcluded children, the adapter was written specifically for it.

image

Review

diosmosis and others added 30 commits November 26, 2021 21:19
@diosmosis
Merge branch 'vue-period-selector' into vue-reporting-menu
15c9025
@diosmosis
migrate most of reporting menu directive and model
d3d5a71
@diosmosis
Use themed font family for input forms to override materialize.css st…
902765c 
…yling
@diosmosis
Merge branch 'local-ui-test-font-fix' into vue-period-selector
94e05ca
@diosmosis
rebuild vue
16885ea
@diosmosis
add a missing div
bac055e
@diosmosis
ui test fixes
1d6d314
@diosmosis
update styling
79687a9
@diosmosis
get to build
baf774a
@diosmosis
get to build
98d6a62
@diosmosis
get to load in the UI w/o error
6699936
@diosmosis
clone result of functions
426cecf
@diosmosis
fix compile issue
0f805af
@diosmosis
migrate widget loader and get to load in UI
25075d6
@diosmosis
rebuild vue
451c56d
@diosmosis
migrate widgetcontainer
c87fc40
@diosmosis
migrate widget bydimension container
40df9a9
@diosmosis
migrate widget + add tooltips directive
f296da6
@diosmosis
quick fix
24d7234
@justinvelluppillai
Updating version to 4.6.0
a1d3808
@diosmosis
loading in page
8db9283
@diosmosis
update expected screenshot
27115a7
@diosmosis
Merge branch 'vue-period-selector' into vue-reporting-pages-model
2b39963
@diosmosis
add wait just in case travis is slow
759c8b7
@diosmosis
Merge branch 'vue-reporting-pages-model' into vue-reporting-menu
6b8e4de
@diosmosis
fix ordering bug
0a67443
@diosmosis
Merge branch 'vue-reporting-menu' into vue-widget-loader
9d35cb3
@diosmosis
add another wait
98fb793
@diosmosis
Merge branch '4.x-dev' into vue-reporting-menu
b2ed03e
@diosmosis
rebuild vue
42dfdf3
@diosmosis diosmosis added the Needs Review PRs that need a code review label Dec 6, 2021
@diosmosis diosmosis marked this pull request as ready for review December 6, 2021 11:14
@diosmosis
Copy link
Member Author

UI tests should be passing for this PR

@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Dec 14, 2021
@diosmosis diosmosis added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Dec 14, 2021
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Dec 22, 2021
peterhashair
peterhashair approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@diosmosis
Copy link
Member Author

tested via loginldap settings page which uses ajax-form (only other use is in LoginSaml I believe)

@diosmosis diosmosis merged commit 1096595 into 4.x-dev Dec 31, 2021
@diosmosis diosmosis deleted the vue-ajax-form branch December 31, 2021 09:07
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diosmosis @peterhashair @justinvelluppillai @mattab