[Vue] migrate remaining directives in CorePluginsAdmin #18433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
Do not close
…#18497) * forward compareSegments in when applying period selector change + check if comparing periods in period selector * built vue files
…class to use kebab case, check for field using css class as well in Widget.vue
…to vue-plugin-settings
peterhashair
approved these changes
Dec 20, 2021
peterhashair
approved these changes
Dec 21, 2021
sgiehl
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Code overall looks fine. Did a quick testing of the UI and it seems everything works fine.
The JS tests are failing, but that seems to be caused by the last PR already. Might be good to fix them before merging.
UI test failures seem to be unrelated to this PR.
| @@ -25,15 +25,9 @@ | |||
|
|
|||
| $timeout(function () { | |||
There was a problem hiding this comment.
Any reason why this file is still needed?
justinvelluppillai
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off of #18432.
Changes:
Changes made to make UI tests pass:
fetch()polyfill library: https://github.com/github/fetch. See the AbortController spec: https://developer.mozilla.org/en-US/docs/Web/API/AbortControllerReview