[Vue] migrate the plugin-settings directive #18432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to vue-plugin-settings
sgiehl
requested changes
Dec 16, 2021
plugins/CorePluginsAdmin/vue/src/PluginSettings/PluginSettings.vue
Outdated
Show resolved
Hide resolved
plugins/CorePluginsAdmin/vue/src/PluginSettings/PluginSettings.vue
Outdated
Show resolved
Hide resolved
11 tasks
|
@diosmosis did a fix for one of the issues in #18453 for this version here. When we type a wrong password in the modal, then close it, |
|
@diosmosis would be good to review #18515 and merge it before pushing any further changes, to avoid merge conflicts. |
|
@sgiehl I will take a look as soon as I can but I will be pretty busy with other things for the moment. |
|
@diosmosis no problem. Btw. I found another regression in TagManager (top controls aren't visible anymore). Shall I create a issue for that and assign it to you? |
|
@sgiehl 👍 sure, go ahead! |
…nagers enabled (#18515) * Update PluginSettings.vue * built vue files Co-authored-by: peterhashair <peterhashair@users.noreply.github.com>
sgiehl
reviewed
Dec 20, 2021
plugins/CorePluginsAdmin/vue/src/PluginSettings/PluginSetting.vue
Outdated
Show resolved
Hide resolved
sgiehl
approved these changes
Dec 21, 2021
justinvelluppillai
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off of #18431.
Changes:
IMPORTANT NOTE: This PR is still using angularjs for expression evaluation. There doesn't seem to be an established library to do something similar, though a handful exist (none of them seem very popular). We'll either have to use one of those or roll our own. I'm not sure which is the best option, but suggestions are welcome.
Review