@diosmosis
Description:
This PR is based off of #18430.
Changes:
- Add an adapter for sitesstore => siteselector model so the angularjs code can be removed.\
- Fix issue in SiteSelector.vue, the previous angularjs version only set the current site to the first site in the list if there was only one site in the Matomo overall. Changing that breaks the manage rollup field.
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
UI tests should be passing for this PR
@github-actions[bot]
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers
@peterhashair
@diosmosis working as expected, test VUE parts, interface, and CSS. I did conflicts resolve for this PR. Can you review it, in case I merge the wrong parts?
@peterhashair I'll check eventually, but these PRs are all based on each other like a chain. The next one to review is https://github.com/matomo-org/matomo/pull/18430, then when that gets merged I'll merge into the next PR, etc. This PR, eg, contains changes in other PRs so I wouldn't want to get this merged right away, instead would look at the PR it's based on first.
This is the link I've been using to look at the PRs in the order that they were created: https://github.com/matomo-org/matomo/pulls?q=is%3Apr+%5BVue%5D+sort%3Acreated-asc+is%3Aopen
@peterhashair fixed
@sgiehl
@diosmosis this seems to work fine. While testing I discovered anther bug in RollUpReporting that seems to be caused by the vue migration (at least it worked with Matomo 4.5).
When the all sites object is added to an roll up, it can't be removed anymore. There is no javascript error, but the dom keeps updating the site elements, without really removing it...
Feel free to merge this one and create another PR for that if you find a fix.
@sgiehl :+1: just found the fix, will create a new PR