[Vue] add site selector model adapter and fix siteselector.vue bug #18431
Conversation
* Use separate div in modals to display notifications otherwise Vue will erase modal content when initializing NotificationGroup component. * built vue files
|
@diosmosis working as expected, test VUE parts, interface, and CSS. I did conflicts resolve for this PR. Can you review it, in case I merge the wrong parts? |
|
@peterhashair I'll check eventually, but these PRs are all based on each other like a chain. The next one to review is #18430, then when that gets merged I'll merge into the next PR, etc. This PR, eg, contains changes in other PRs so I wouldn't want to get this merged right away, instead would look at the PR it's based on first. This is the link I've been using to look at the PRs in the order that they were created: https://github.com/matomo-org/matomo/pulls?q=is%3Apr+%5BVue%5D+sort%3Acreated-asc+is%3Aopen |
…#18497) * forward compareSegments in when applying period selector change + check if comparing periods in period selector * built vue files
diosmosis
added
Do not close
…class to use kebab case, check for field using css class as well in Widget.vue
|
@peterhashair fixed |
|
@diosmosis this seems to work fine. While testing I discovered anther bug in RollUpReporting that seems to be caused by the vue migration (at least it worked with Matomo 4.5). |
|
@sgiehl 👍 just found the fix, will create a new PR |
justinvelluppillai
added
the
not-in-changelog
Description:
This PR is based off of #18430.
Changes:
Review