[Vue] migrate reporting page directive #18430
Conversation
* Use separate div in modals to display notifications otherwise Vue will erase modal content when initializing NotificationGroup component. * built vue files
…roperly to widgets, take columns param into account when re-rendering a page
| v-for="widget in widgets" | ||
| :key="widget.uniqueId" | ||
| > | ||
| <Widget |
There was a problem hiding this comment.
I guess we need to add some special class or attribute here. We have some javascript looking for [piwik-widget], which no longer does exist. See
matomo/plugins/CoreHome/javascripts/dataTable.js
Line 1934 in b7bfb36
This also causes the UI test failure where a tooltip is still visible.
There was a problem hiding this comment.
👍 nice catch, I'll put looking for selectors like this on my checklist.
…#18497) * forward compareSegments in when applying period selector change + check if comparing periods in period selector * built vue files
|
@sgiehl updated |
…class to use kebab case, check for field using css class as well in Widget.vue
|
fixed another test failure + made some tweaks |
|
@peterhashair I don't see this failure in https://app.travis-ci.com/github/matomo-org/matomo/builds/243453117 can you link to it? |
|
@peterhashair nevermind, I see it now. |
|
@diosmosis seems to work in general. But I got this JS error when a report page is loaded: |
|
@sgiehl fixed that |
justinvelluppillai
added
the
not-in-changelog
Description:
This PR is based off of #18429.
Changes:
Review