@diosmosis opened this Pull Request on December 2nd 2021 Member

Description:

This PR is based off of #18429.

Changes:

  • Migrate piwik-reporting-page directive.
  • Migrate reportingPageModel service to store.
  • Moving interfaces around so different services can use them.

image

Review

@diosmosis commented on December 5th 2021 Member

UI tests should be passing for this PR

@diosmosis commented on December 14th 2021 Member

@sgiehl updated

@diosmosis commented on December 14th 2021 Member

fixed another test failure + made some tweaks

@diosmosis commented on December 15th 2021 Member
@diosmosis commented on December 15th 2021 Member

@peterhashair nevermind, I see it now.

@sgiehl commented on December 15th 2021 Member

@diosmosis seems to work in general. But I got this JS error when a report page is loaded:
image

@diosmosis commented on December 15th 2021 Member

@sgiehl fixed that

This Pull Request was closed on December 15th 2021
Powered by GitHub Issue Mirror