@diosmosis opened this Pull Request on December 2nd 2021 Member

Description:

This PR is based off of #18428.

Changes:

  • Migrate piwik-widget-bydimension-container directive.
  • Migrate piwik-widget-container directive.
  • Migrate piwik-widget directive.
  • Do not show ajax request failures if not logged in.
  • Remove SiteSelector adapter hack since it is fixed by the Field adapter ng model binding + remove selectedSite state since it's not used anymore.
  • Create v-tooltips directive to encapsulate jquery UI tooltips usage. Useful since we want to remove it when an element disappears, not the component.
  • Add Widgets store for handling results of widgetsHelper.getAvailableWidgets().

image

Review

@diosmosis commented on December 5th 2021 Member

UI tests should be passing for this PR

@diosmosis commented on December 10th 2021 Member

@sgiehl I'll fix these in the other branches individually. I will have limited availability however for the next couple weeks, so it's ok to do one Vue review a day (if there's a PR to review) in my opinion. I won't have time to get to everything.

This Pull Request was closed on December 13th 2021
Powered by GitHub Issue Mirror