Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] migrate piwik-widget and related directives #18429

Merged
merged 482 commits into from Dec 13, 2021
Merged

[Vue] migrate piwik-widget and related directives #18429

merged 482 commits into from Dec 13, 2021

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Dec 2, 2021 •
edited

Description:

This PR is based off of #18428.

Changes:

  • Migrate piwik-widget-bydimension-container directive.
  • Migrate piwik-widget-container directive.
  • Migrate piwik-widget directive.
  • Do not show ajax request failures if not logged in.
  • Remove SiteSelector adapter hack since it is fixed by the Field adapter ng model binding + remove selectedSite state since it's not used anymore.
  • Create v-tooltips directive to encapsulate jquery UI tooltips usage. Useful since we want to remove it when an element disappears, not the component.
  • Add Widgets store for handling results of widgetsHelper.getAvailableWidgets().

image

Review

@diosmosis
more fixes
e980a8b
@diosmosis
even more fixes
ed67d73
@diosmosis
another ui test fix
2f59bd7
@diosmosis
more type fixes
af6ddd4
@diosmosis
rebuilt vue JS
2700b5f
@diosmosis
couple more fixes
18a2814
@diosmosis
undo debugging
acd1184
@diosmosis
do not convert undefined to bool
3f51778
@diosmosis
update screenshot
d343d20
@diosmosis
another bool checking fix
315f7c5
@diosmosis
rebuild vue files
c0b0902
@diosmosis
more fixes
a5c6d05
@diosmosis
initial site value in field is assumed to be encoded
1c5f95d
@diosmosis
file headers and custom field component support
53279b9
@diosmosis
get custom component field code to work
716917b
@diosmosis
rebuild vue
9de96d0
@diosmosis
allow using angularjs templateFile for custom field (for BC)
a8b14c6
@diosmosis
get angularjs template embedding to work for rollupreporting at least
7fd79a2
@diosmosis
deal with some in source TODO items
ec5d5f7
@diosmosis
fix a couple more issues
6889a47
@diosmosis
Use separate div in modals to display notifications otherwise Vue wil…
bd6cd43 
…l erase modal content when initializing NotificationGroup component.
@diosmosis
Merge branch 'next_release' into vue-form-field
49eb8b9
@diosmosis
Merge branch 'vue-modal-notification-bug' into vue-form-field
d3ac38b
@diosmosis
build again
7cf8ccb
@diosmosis
refactor some code and fix an issue with checkbox array field handlin…
a0f0e91 
…g in angularjs
@diosmosis
more fixes
4a52271
@diosmosis
another fix
721f8ec
@diosmosis
even more fixes
767c389
@diosmosis
remove more todo
531406f
@diosmosis
hopefully the last changes
24c07cd
@diosmosis
Copy link
Member Author

UI tests should be passing for this PR

@diosmosis diosmosis added the Needs Review PRs that need a code review label Dec 5, 2021
@diosmosis diosmosis marked this pull request as ready for review December 5, 2021 12:34
@diosmosis @sgiehl
Update plugins/CoreHome/stylesheets/layout.less
5f45602 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@diosmosis
Copy link
Member Author

@sgiehl I'll fix these in the other branches individually. I will have limited availability however for the next couple weeks, so it's ok to do one Vue review a day (if there's a PR to review) in my opinion. I won't have time to get to everything.

sgiehl
sgiehl approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and I wasn't able to find any related issues while clicking through the UI

@sgiehl sgiehl merged commit ae5d208 into 4.x-dev Dec 13, 2021
@sgiehl sgiehl deleted the vue-widget branch December 13, 2021 14:00
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diosmosis @sgiehl @justinvelluppillai @mattab