Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] migrate widget-loader directive #18428

Merged
merged 463 commits into from Dec 10, 2021
Merged

[Vue] migrate widget-loader directive #18428

merged 463 commits into from Dec 10, 2021

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Dec 2, 2021

Description:

This PR is based off of #18423.

Changes:

  • Migrate widgetloader directive.
  • Allow sending custom headers in AjaxHelper.fetch

image

Review

@diosmosis
Copy link
Member Author

UI tests should be passing for this PR

@peterhashair
Copy link
Contributor

there is a test that failed, I think it's related to this. Maybe need to update the tests.

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look through the code and did some basic local testing. Besides the one comment I already left, I guess it looks good so far. Guess some tests / expected files will need an update

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed another small fix to fix the js tests and updated the expected screenshot files. Green build 🎉

@sgiehl sgiehl merged commit 6639cce into 4.x-dev Dec 10, 2021
@sgiehl sgiehl deleted the vue-widget-loader branch December 10, 2021 11:34
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants