@diosmosis opened this Pull Request on December 2nd 2021 Member

Description:

This PR is based off of #18423.

Changes:

  • Migrate widgetloader directive.
  • Allow sending custom headers in AjaxHelper.fetch

image

Review

@peterhashair commented on December 3rd 2021 Contributor

the interface worked as expected, but it seems like failed a test, not sure that is related. but it doesn't close the notification bar on the test I think.

 2) Notifications
       should still show persistent notifications on reload:
          the 'compare' command output could not be parsed, should be an integer, got: compare-im6.q16: image widths or heights differ `/home/travis/build/matomo-org/matomo/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_reloaded.png' @ error/compare.c/CompareImageCommand/1000.
            Generated screenshot: /home/travis/build/matomo-org/matomo/tests/UI/processed-ui-screenshots/Notifications_reloaded.png
            Expected screenshot: /home/travis/build/matomo-org/matomo/plugins/CoreHome/tests/UI/expected-screenshots/Notifications_reloaded.png

            Url to reproduce: http://localhost/tests/PHPUnit/proxy/?module=CoreAdminHome&action=home&idSite=1&period=day&date=yesterday
            No captured console logs
@diosmosis commented on December 5th 2021 Member

UI tests should be passing for this PR

@peterhashair commented on December 8th 2021 Contributor

there is a test that failed, I think it's related to this. Maybe need to update the tests.

This Pull Request was closed on December 10th 2021
Powered by GitHub Issue Mirror