New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] migrate widget-loader directive #18428
Conversation
…ays the same as what is in the DB
5ad224f
to
5fd728b
Compare
UI tests should be passing for this PR |
there is a test that failed, I think it's related to this. Maybe need to update the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look through the code and did some basic local testing. Besides the one comment I already left, I guess it looks good so far. Guess some tests / expected files will need an update
Co-authored-by: Stefan Giehl <stefan@matomo.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed another small fix to fix the js tests and updated the expected screenshot files. Green build 🎉
Description:
This PR is based off of #18423.
Changes:
Review