Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgetize language reworked #18425

Merged
merged 2 commits into from Dec 5, 2021
Merged

Widgetize language reworked #18425

merged 2 commits into from Dec 5, 2021

Conversation

comradekingu
Copy link
Contributor

Review

@sgiehl sgiehl added the c: i18n For issues around internationalisation and localisation. label Dec 1, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Dec 1, 2021
@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 1, 2021
@justinvelluppillai @sgiehl
Update plugins/Widgetize/lang/en.json
97278b9 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
justinvelluppillai
justinvelluppillai approved these changes Dec 5, 2021
View reviewed changes
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some failing UI tests but also some failing from an earlier merge, so will merge this and then fix them in a separate PR.

@justinvelluppillai justinvelluppillai merged commit 5252961 into matomo-org:4.x-dev Dec 5, 2021
@justinvelluppillai justinvelluppillai mentioned this pull request Dec 5, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
c: i18n For issues around internationalisation and localisation. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@comradekingu @justinvelluppillai @sgiehl