Remove unneeded plugin.json from CoreVue plugin #18421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
|
Looks 4.6.1 has already been released. Will there be a 4.6.2? ping @justinvelluppillai |
sgiehl
approved these changes
Dec 1, 2021
|
This one by the looks would be only relevant for tests so it maybe doesn't need to be included in 4.6.2? |
|
@tsteur technically it doesn't, but the test will stay broken until 4.7.0 is released, so it might be rather inconvenient |
justinvelluppillai
changed the title
justinvelluppillai
added a commit
that referenced
this pull request
Dec 16, 2021
* Fix for misaligned evolution trend icons (#18323) * Aligned evolution trend icons, text tweak * Update plugins/MultiSites/angularjs/dashboard/dashboard.directive.less Co-authored-by: Stefan Giehl <stefan@matomo.org> * Hide feedback banner in zen mode (#18329) * [Vue] 4.6.0 fixes (#18334) * feedback plugin may not be loaded * fix copy paste * async/await not supported * built UMDs * [Vue] use jQuery click for expand on click (#18341) * use jQuery click for expand on click * undo submodule change * 4.6.0-rc2 * [Vue] fix modal notification placement (#18377) * Use separate div in modals to display notifications otherwise Vue will erase modal content when initializing NotificationGroup component. * built vue files * Updating version to 4.6.0 * [Vue] date picker viewDate property is not kept up to date (#18385) * viewDate ref is not kept up to date * rebuild corehome * 4.6.1-rc1 * 4.6.1 * [Vue] emit/broadcast on scope the method was called on not rootScope (#18419) * emit/broadcast on correct scope in wrapper * rebuild vue * remove plugin.json from CoreVue, it is not needed and causes some UI tests to fail (#18421) * Ensure UTF8mb4 conversion command always enables tracking again (#18444) * Ensure UTF8mb4 conversion command always enables tracking again * apply review feedback * small code improvement * Ignore segment errors in update script (#18455) * 4.6.2-rc1 * Ensure update to 4.6.2 removes some files (#18473) * 4.6.2 release! * built vue files Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com> Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: dizzy <diosmosis@users.noreply.github.com> Co-authored-by: Matthieu Aubry <mattab@users.noreply.github.com> Co-authored-by: justinvelluppillai <justinvelluppillai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
…causes some tests to fail.
Review