@diosmosis opened this Pull Request on December 1st 2021 Member

Description:

AngularJS scopes inherit directly from their parent, so overwriting $emit/$broadcast on the $rootScope changes it for everyone. Which is a problem if the overwritten function uses $rootScope directly to broadcast, and not the given scope. ('$destroy' on a child scope for example can destroy many scopes it shouldn't).

Review

@tsteur commented on December 1st 2021 Member

Do we know what this breaks for the user? Generally we could merge it as long as we don't break anything else with it.
For it to be in 4.6.2 we would need a PR against next_release branch

@sgiehl commented on December 1st 2021 Member

This caused at least the problem in ActivityLog, not sure if anything else is still undiscovered

@diosmosis commented on December 1st 2021 Member

Updated the base branch

@tsteur commented on December 2nd 2021 Member

@diosmosis some UI tests are now failing, not sure if this is expected?

@diosmosis commented on December 2nd 2021 Member

@tsteur no not expected, looking into it now

@diosmosis commented on December 2nd 2021 Member

@tsteur most failures are random, the rest are due to database version being different in the screenshot. I updated those.

@tsteur commented on December 2nd 2021 Member

👍 good to merge then

@tsteur commented on December 2nd 2021 Member

it's probably not needed to update screenshots in next_release as it might be fixed then in 4.x-dev I would assume. Not sure what best flow is there

@diosmosis commented on December 2nd 2021 Member

@tsteur ok, I won't update (I actually pushed them to the wrong branch)

This Pull Request was closed on December 2nd 2021
Powered by GitHub Issue Mirror