Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matomo 4.6.0 reports 'vendor/lox/xhprof/bin/xhprofile' as problematic for File Integrity #18418

Closed
mig5 opened this issue Dec 1, 2021 · 6 comments
Closed

Matomo 4.6.0 reports 'vendor/lox/xhprof/bin/xhprofile' as problematic for File Integrity #18418

mig5 opened this issue Dec 1, 2021 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.6.2

Comments

@mig5
Copy link

mig5 commented Dec 1, 2021 •
edited

Expected Behavior

After upgrading from Matomo 4.5.0 to 4.6.0 (swapping out the codebase with the new one from the tarball, and just retaining key files like config.ini.php), I expected to see no File Integrity issues in the Matomo admin interface.

Current Behavior

The File Integrity area of the Matomo admin dashboard (System Check page) reported vendor/lox/xhprof/bin/xhprofile as being unexpected.

File integrity check failed and reported some errors. You should fix this issue and then refresh this page until it shows no error.
Files were found in your Matomo, but we didn't expect them.
--> Please delete these files to prevent errors. <--

File to delete: vendor/lox/xhprof/bin/xhprofile


To delete all these files at once, you can run this command:
rm "/var/www/html/piwik_4.6.0/vendor/lox/xhprof/scripts/xhprofile.php"

It recommended to remove it so I did. Note also the different file in the above command example (scripts/xhprofile.php) even though it's a different file marked as unexpected.

Possible Solution

Either don't ship this file in the 4.6.0 tarball, or add it to list of expected files?

Steps to Reproduce (for Bugs)

Install 4.6.0 from http://builds.matomo.org/matomo-4.6.0.tar.gz

Your Environment

  • Matomo Version: 4.6.0
  • PHP Version: PHP 7.2.34-28+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Nov 19 2021 06:36:36) ( NTS )
  • Server Operating System: Ubuntu 18.04
  • Browser: Firefox 78.15.0esr (64-bit)
  • Operating System: Debian 10 (QubesOS)
@mig5 mig5 added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Dec 1, 2021
@tsteur tsteur added this to the 4.6.1 milestone Dec 1, 2021
@sgiehl
Copy link
Member

sgiehl commented Dec 1, 2021

@mig5 would you mind checking if that happens with 4.6.1 as well?

@prbt2016
Copy link

prbt2016 commented Dec 1, 2021 •
edited

Hello,

I get the same issue as above while starting installation for Matomo 4.6.1 i.e :

File integrity check failed and reported some errors. You should fix this issue and then refresh this page until it shows no error.

Files were found in your Matomo, but we didn't expect them.
--> Please delete these files to prevent errors. <--

File to delete: vendor/lox/xhprof/bin/xhprofile

To delete all these files at once, you can run this command:
rm "/{{PATH}}/{{TO}}/{{MATOMO}}/vendor/lox/xhprof/bin/xhprofile"

image

Could you please check and fix?

@rogamoore
Copy link

I also have the same in 4.6.1

The file in vendor/lox/xhprof/bin/xhprofile seems to be a symbolic link. It points to vendor/lox/xhprof/scripts/xhprofile.php. For the latter, there is an entry in the manifest:

		"vendor/lox/xhprof/scripts/xhprofile.php" => array("318", "aada44020058ead73cc477808fa9c4f6"),

So I guess, the manifest generation script should handle symbolic links differently.

@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Dec 1, 2021
@tsteur tsteur mentioned this issue Dec 1, 2021
Closed
@tsteur
Copy link
Member

tsteur commented Dec 2, 2021

Some files are also being reported in #18415 (comment)
image
and #18411 (comment)
image

I will create an issue to double check if there's a possibility to delete these files automatically. Maybe in the mean time an update script could try to remove the no longer needed files so not everyone sees these messages and gets confused?

@tsteur tsteur mentioned this issue Dec 2, 2021
Open
@tsteur
Copy link
Member

tsteur commented Dec 7, 2021

can this one be closed maybe?

@sgiehl
Copy link
Member

sgiehl commented Dec 7, 2021

I think so. The next release should at least solve a couple of the files in the lists above. All others should be fixed with 4.7.0 then.

@tsteur tsteur closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.6.2
Development

No branches or pull requests
5 participants
@mig5 @tsteur @sgiehl @rogamoore @prbt2016