@peterhashair opened this Issue on November 30th 2021 Contributor

Expected Behavior

Stick table should be canceled on the table has X-axis scrolling

Current Behavior

I was on another issue notice the stick table has a bug, that issue is related to one of my PR. https://github.com/matomo-org/matomo/pull/18124

The problem is when the dataTableScroller is not visible during an ajax load. it won't process overflow-x', 'scroll', leading the entire page to scroll on the X-axis.

Steps to Reproduce (for Bugs)

To reproduce this, on the goals overview page, when you have more than 10 goals, it should appear.

Related Code

https://github.com/matomo-org/matomo/blob/9efa63a654145fcb315d16c5e6d21ab3b96c6f01/plugins/CoreHome/javascripts/dataTable.js#L119-L129

Possible Solution

I guess there are 2 solutions. Wait ajax is finished if there is one. then call enable function, or do an internal time, check it class is visible, once it's visible run the function and clear the timer.

Powered by GitHub Issue Mirror