Added table of contents for general settings #18404
Conversation
bx80
added
c: Usability
There was a problem hiding this comment.
FYI I've done a quick test here as well because I saw the screenshot and was wondering if we could maybe somehow shorten some of the titles because they are quite long and it takes quite a bit to read/scan this menu? Like could we rename somehow CONFIGURATION FOR SERVER VARIABLES USED BY GEOIP 2 SERVER to GeoIp
btw the link for geoip did not work for me
Also noticed the CORS link is missing
I'm also wondering if maybe regular case would be better readable
and thinking maybe we have to put a space before capital letters there just to have it bit more human readable? We're doing the same on the Marketplace using something like below but it's in PHP
function matomoAddSpacesToCamcelCase($name)
{
$parts = preg_split('/(?=[A-Z0-9])/', $name);
$name = '';
foreach ($parts as $part) {
if (strlen($part) > 1) {
$name .= ' ';
}
$name .= $part;
}
return trim($name);
}
|
The text wrapping issue was caused by there not being a suitable white space character between links, they look like they have spaces but it's actually a right margin applied by the materialize classes. The long plugin names were because I was using the plugin title rather than the plugin name, I've switched to using the plugin name which is shorter, this has also fixed the broken GeoIp2 link. The 'CORS' and 'Trusted Matomo Hostname' sections both come from the I've also overridden the materialize card uppercase text CSS and added a space before each capital letter for plugin names, which does look a lot better. |
There was a problem hiding this comment.
Looks good to me. Not sure if we want the tracking code TOC to look the same now (maybe a separate issue anyway)?
Will leave open in case @tsteur has any other feedback.
|
@bx80 fyi just saw there's actually maybe an issue with SEOWebVitals plugin where it makes
|
Description:
Fixes #13837
Adds a table of contents to the general settings page. Anchors and table of content links for plugin sections are automatically added by the controller.
Review