Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation pages might send API request to API.getPagesComparisonsDisabledFor #18402

Closed
sgiehl opened this issue Nov 29, 2021 · 0 comments · Fixed by #18525
Closed

Installation pages might send API request to API.getPagesComparisonsDisabledFor #18402

sgiehl opened this issue Nov 29, 2021 · 0 comments · Fixed by #18525
Assignees
@peterhashair
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.7.0

Comments

@sgiehl
Copy link
Member

sgiehl commented Nov 29, 2021

When opening Matomo in an uninstalled state, Matomo will display the installation.
At this state the URL might not contain a module. Thus the check doesn't work here:

matomo/plugins/CoreHome/vue/src/Comparisons/Comparisons.store.ts

Lines 320 to 325 in 24c07cd

if (matomoModule === 'CoreUpdater'
|| matomoModule === 'Installation'
) {
this.privateState.comparisonsDisabledFor = [];
return;
}

This results in an failing API request.
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Nov 29, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Nov 29, 2021
@peterhashair peterhashair mentioned this issue Dec 20, 2021
Merged
11 tasks
@peterhashair peterhashair self-assigned this Dec 20, 2021
@peterhashair peterhashair linked a pull request Dec 20, 2021 that will close this issue
Installation pages send API request to API.getPagesComparisonsDisabledFor #18525
Merged
11 tasks
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging a pull request may close this issue.

Installation pages send API request to API.getPagesComparisonsDisabledFor matomo-org/matomo
3 participants
@justinvelluppillai @sgiehl @peterhashair