Ensure initially selected site is correctly emitted #18401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
sgiehl
added
the
not-in-changelog
|
@sgiehl this should be fixed in the vue-form-field branch, can you check? The selectedSite state is removed so this fix wouldn't apply there. |
|
will check that |
|
@diosmosis yes. works with the changes of the other PR. closing this one then. |
sgiehl
added
duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When the site selector is used as a form field, the initially selected site might currently not be emitted correctly.
This can be seen e.g. when trying to add a new site config in search performance plugin.
The site selector initially shows a site, but the form field it is referenced to (using
ng-model="form.site.id") won't have an initial value.Review