@sgiehl opened this Pull Request on November 29th 2021 Member

Description:

When the site selector is used as a form field, the initially selected site might currently not be emitted correctly.
This can be seen e.g. when trying to add a new site config in search performance plugin.
The site selector initially shows a site, but the form field it is referenced to (using ng-model="form.site.id") won't have an initial value.

Review

@diosmosis commented on November 29th 2021 Member

@sgiehl this should be fixed in the vue-form-field branch, can you check? The selectedSite state is removed so this fix wouldn't apply there.

@sgiehl commented on November 29th 2021 Member

will check that

@sgiehl commented on November 29th 2021 Member

@diosmosis yes. works with the changes of the other PR. closing this one then.

This Pull Request was closed on November 29th 2021
Powered by GitHub Issue Mirror