New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert sparkline api to one request - fixes archive #18399
Conversation
update lock
update sparkline
update title link
add comments
update loader
update template
@tsteur do you want to try that one, I think this is kind of working, reduce my CPU a little bit on my local on a one year period, still have failed some XML compare tests but should be fine, I will fix and tidy code more, once we confirm it reduce the load. |
@peterhashair let's maybe keep the changes for the lock separate and only apply the UI changes here. Be good to check out my comment in chat to make use of Visualisations as much as possible. |
@tsteur right, I was stuck on here, so go for the template option. Let me convert to Visualisations. $view = ViewDataTableFactory::build(Sparklines::ID, $apiMethod, 'Goals.' . __METHOD__, $forceDefault = true); |
update to visualise
update controller
revert lock
update matrix
update config title
remove template
remove mutilple
us getMetrics
update tests
@tsteur as we discussed. I used the goal API |
Awesome, can you check if it loads faster now? |
@tsteur yes, about 3-5 seconds faster compared to load period for 6 months on my local. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me and definitely a bit quicker. I've flagged a couple of very minor code tidies. 👍
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
# Conflicts: # plugins/CoreHome/vue/dist/CoreHome.umd.min.js
update umd js
@peterhashair @bx80 This actually kind of broke the goals overview page. If you would have had a look at the UI test failures you would have been able to see that. See https://builds-artifacts.matomo.org/matomo-org/matomo/m-18088-fixes-archive/52262/GoalsPages_overview.png |
@sgiehl right let me fix that it. But I got a little confused here, it seems like the preview Test hides the revenue doesn't matter on which conditions (I mean is that on purpose or a regression), the new approach has actually loaded the revenue when |
@peterhashair Actually it doesn't really matter if that would have been a regression or not. It was not part of the issue to change the content of the reports in any way. And it's actually not only the additional sparkline, also the headline misses |
Description:
Fixes: #18088.
convert sparking API to one request - fixes archive
Copy the logic from here :
matomo/plugins/Ecommerce/Controller.php
Line 37 in e321847
Review