Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include another local file if present in UI tests to allow extending the screenshot testing lib. #18392

Merged
merged 1 commit into from Nov 28, 2021

Conversation

diosmosis
Copy link
Member

Description:

Using this locally to add an extra afterEach() hook to every test suite that outputs the HTML on the page to a directory. Diffing these makes it quicker to resolve certain issues encountered in the vue migration. (The logic is not actually useful outside of the vue migration so doesn't need to be in core.)

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Nov 28, 2021
@bx80 bx80 added this to the 4.7.0 milestone Nov 28, 2021
@bx80 bx80 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 28, 2021
@bx80 bx80 merged commit f3bdbb8 into 4.x-dev Nov 28, 2021
@bx80 bx80 deleted the allow-ui-test-extension branch November 28, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants