Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow skipping logic that exits w/ an error code if warnings are detected in the output #18391

Merged
merged 4 commits into from Nov 29, 2021

Conversation

diosmosis
Copy link
Member

Description:

This is for automation for the vue migration, specifically being able to run vue:build and tell if there is a legitimate error in the file.

Review

…warnings are detected in the output (for automation)
@diosmosis diosmosis added the Needs Review PRs that need a code review label Nov 28, 2021
@bx80 bx80 self-requested a review November 28, 2021 20:13
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted an integration test exception on the travis build:

Uncaught exception: /home/travis/build/matomo-org/matomo/vendor/symfony/console/Symfony/Component/Console/Input/Input.php(180): The "ignore-warn" option does not exist. [Query: , CLI mode: 1]
[InvalidArgumentException]                
The "ignore-warn" option does not exist.  

@diosmosis
Copy link
Member Author

@bx80 thanks for the catch!

ping @tsteur since this is an API change

@tsteur
Copy link
Member

tsteur commented Nov 29, 2021

@diosmosis not sure I fully understand the regression. As long as ignore-warn is optional and we keep existing behaviour it should be fine?

@diosmosis
Copy link
Member Author

diosmosis commented Nov 29, 2021

@tsteur it's not a regression, I need the change for some automation, specifically to be able to run vue:build and check whether it actually built something rather than it failing because a WARNING was emitted (see #18392 for some details on the use case). I'm not sure how good the parameter name is.

@tsteur
Copy link
Member

tsteur commented Nov 29, 2021

Name is fine by me. I can't think of a better name except some really long ones but they be too long.

I would however adjust the description to also include error logs Return 0 exit code even if there are warnings or errors detected. Although maybe that's misleading too as it then might sound like we would catch any kind of error and return 0 exit code?

@diosmosis
Copy link
Member Author

@tsteur

I would however adjust the description to also include error logs Return 0 exit code even if there are warnings or errors detected. Although maybe that's misleading too as it then might sound like we would catch any kind of error and return 0 exit code?

That sounds better. I can make it Return 0 exit code even if there are warning logs or error logs detected in the command output. to be more specific.

@tsteur
Copy link
Member

tsteur commented Nov 29, 2021

Awesome, thanks 👍

@diosmosis diosmosis merged commit e321847 into 4.x-dev Nov 29, 2021
@diosmosis diosmosis deleted the console-ignore-warn branch November 29, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants