New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to allow skipping logic that exits w/ an error code if warnings are detected in the output #18391
Conversation
…warnings are detected in the output (for automation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spotted an integration test exception on the travis build:
Uncaught exception: /home/travis/build/matomo-org/matomo/vendor/symfony/console/Symfony/Component/Console/Input/Input.php(180): The "ignore-warn" option does not exist. [Query: , CLI mode: 1]
[InvalidArgumentException]
The "ignore-warn" option does not exist.
@diosmosis not sure I fully understand the regression. As long as |
@tsteur it's not a regression, I need the change for some automation, specifically to be able to run vue:build and check whether it actually built something rather than it failing because a WARNING was emitted (see #18392 for some details on the use case). I'm not sure how good the parameter name is. |
Name is fine by me. I can't think of a better name except some really long ones but they be too long. I would however adjust the description to also include error logs |
That sounds better. I can make it |
Awesome, thanks 👍 |
Description:
This is for automation for the vue migration, specifically being able to run vue:build and tell if there is a legitimate error in the file.
Review