@diosmosis
Description:
This is for automation for the vue migration, specifically being able to run vue:build and tell if there is a legitimate error in the file.
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
@tsteur
@diosmosis not sure I fully understand the regression. As long as ignore-warn is optional and we keep existing behaviour it should be fine?
@tsteur it's not a regression, I need the change for some automation, specifically to be able to run vue:build and check whether it actually built something rather than it failing because a WARNING was emitted (see https://github.com/matomo-org/matomo/pull/18392 for some details on the use case). I'm not sure how good the parameter name is.
Name is fine by me. I can't think of a better name except some really long ones but they be too long.
I would however adjust the description to also include error logs Return 0 exit code even if there are warnings or errors detected. Although maybe that's misleading too as it then might sound like we would catch any kind of error and return 0 exit code?
I would however adjust the description to also include error logs
Return 0 exit code even if there are warnings or errors detected. Although maybe that's misleading too as it then might sound like we would catch any kind of error and return 0 exit code?
That sounds better. I can make it Return 0 exit code even if there are warning logs or error logs detected in the command output. to be more specific.
Awesome, thanks 👍