Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use themed font family for input forms to override materialize.css styling #18390

Merged
merged 1 commit into from Nov 29, 2021

Conversation

diosmosis
Copy link
Member

Description:

I noticed locally when running UI tests that materialize.css has some styles that set the font-family for text controls. This caused them to use the "Ubuntu" font locally, while everything styled by Matomo's CSS used "Liberation Sans" (from querying for sans-serif). Overriding that makes some UI tests pass locally for me now.

Review

@diosmosis diosmosis added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Nov 27, 2021
@sgiehl sgiehl merged commit 82aef0b into 4.x-dev Nov 29, 2021
@sgiehl sgiehl deleted the local-ui-test-font-fix branch November 29, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants