[Vue] migrate reportingPagesModel and reportMetadataModel #18389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te if no translations are loaded
…larjs comment no longer being there)
…on groups to work
… to be transformed in createAngularAdapter
|
@diosmosis could you resolve the conflicts? I would review this one next then. |
|
@sgiehl done + fixed some other issues |
|
tests are passing for this one |
|
Fixed a couple bugs that are currently showing in the UI tests in the next PR: vue-reporting-menu |
sgiehl
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off of #18382
Changes:
Review