Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve password handling in SMTP configuration #18387

Merged
merged 1 commit into from Nov 27, 2021
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 26, 2021

Description:

This PR contains the following changes to the Mail configuration UI:

  • As soon as the hostname is changed, the password will be cleared (unless the password has already been changed before)
  • Focusing the password field will automatically select all it's content (if the password hadn't been changed already)

Review

@sgiehl sgiehl added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Nov 26, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Nov 26, 2021
@bx80 bx80 merged commit 087678f into 4.x-dev Nov 27, 2021
@bx80 bx80 deleted the improvesmtpconfig branch November 27, 2021 05:57
sgiehl added a commit that referenced this pull request Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants