@sgiehl opened this Pull Request on November 26th 2021 Member

Description:

missed that in https://github.com/matomo-org/matomo/pull/18309

fixes #18374

Review

@MichaIng commented on November 26th 2021
@sgiehl commented on November 26th 2021 Member

@MichaIng thanks for spotting that. I've pushed a fix.

@justinvelluppillai commented on December 2nd 2021 Contributor

@sgiehl were you able to reproduce this issue? I have been unsuccessful, even calling $form->getElementsByName() directly doesn't give any error for me in PHP8.1.

The changes look fine but it'd be good to see them fix an actual issue that I can repro 😝

@sgiehl commented on December 2nd 2021 Member

Actually I couldn't. Those I could reproduce were already fixed in another PR.

@MichaIng commented on December 10th 2021

I'm not sure how it could have happened, but Matomo v4.6.2 has now been released without this commit. Ah, I see now the v4.7.0 milestone, just wondering why since this is a trivial but effective fix without any backwards compatibility issues 🤔. However, I'll re-apply it again manually.

This Pull Request was closed on December 2nd 2021
Powered by GitHub Issue Mirror