@diosmosis opened this Pull Request on November 25th 2021 Member

Description:

Changes:

  • Use separate div in modals to display notifications otherwise Vue will erase modal content when initializing NotificationGroup
    component.
  • make sure modal notifications have the right group so they are only displayed in the modal.

This should be visible in the TagManager tests.

Review

@sgiehl commented on November 25th 2021 Member

@diosmosis any hint how to reproduce that quickly, so it's easy to confirm if the fix works or not?

@diosmosis commented on November 25th 2021 Member

@sgiehl in the tag manager, click on manage versions, click import to launch the import modal, then enter invalid json and submit the form ('overwrite current draft with this version'). The notifications will replace the modal content instead of being prepended to it.

This Pull Request was closed on November 26th 2021
Powered by GitHub Issue Mirror