Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goals by dimension view might not fully show #18373

Closed
tsteur opened this issue Nov 24, 2021 · 1 comment · Fixed by #18386
Closed

Goals by dimension view might not fully show #18373

tsteur opened this issue Nov 24, 2021 · 1 comment · Fixed by #18386
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.7.0

Comments

@tsteur
Copy link
Member

tsteur commented Nov 24, 2021

image

I think this has happened the first time around merging https://github.com/matomo-org/matomo/pull/18243/files

I can reproduce this sometimes locally when I have say 15 goals, and load a range etc.

It's like the "by dimension" view loads faster than any of the goal reports and then maybe thinks there's less width available or something.

Not 100% sure it's a regression but haven't really noticed this before
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Nov 24, 2021
@tsteur tsteur added this to the 4.6.0 milestone Nov 24, 2021
@sgiehl
Copy link
Member

sgiehl commented Nov 25, 2021

This might more likely be a regression from the sticky headers. I'm able to reproduce that locally on the goals overview, when switching between custom date ranges (not on the initial page load), but didn't yet find a proper fix.
The problem seems to be here:

matomo/plugins/CoreHome/javascripts/dataTable.js

Lines 428 to 434 in 8066b35

var $table = $('table.dataTable', domElem);
if ($table.closest('.reportsByDimensionView').length) {
var requiredTableWidth = $table.width() - 40; // 40 is padding on card content
if (domElem.width() > requiredTableWidth) {
domElem.css('max-width', requiredTableWidth + 'px');
}
}

For some reason $table.width() is only 100 in some cases and thus the max-width is set to 60.
I tried a couple of fixes, but each fix I tried broke it somewhere else. If anyone else wants to have a look, feel free to do so. I already spent too much time with that fragile code 🤯 If not I might try to continue with that tomorrow.

@sgiehl sgiehl self-assigned this Nov 26, 2021
@sgiehl sgiehl mentioned this issue Nov 26, 2021
Merged
11 tasks
@sgiehl sgiehl linked a pull request Nov 26, 2021 that will close this issue
Ensure javascript of a datatable only initializes itself #18386
Merged
11 tasks
@justinvelluppillai justinvelluppillai modified the milestones: 4.6.0, 4.7.0 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging a pull request may close this issue.

Ensure javascript of a datatable only initializes itself matomo-org/matomo
3 participants
@tsteur @justinvelluppillai @sgiehl