@sgiehl opened this Pull Request on November 24th 2021 Member

Description:

This is a small draft how to solve issues that might occur in MariaDb only.
I've only spent a couple of minutes to do the changes, so I'm not even sure if it would even fully work.

I currently don't have time to finish this PR or even test if everything works as expected.
If someone has some time, feel free to pick it up.

When finished this aims to fix #18360

Review

@jorgeuos commented on November 24th 2021

I'm curios though if there's other functionality that looks for SELECT in their queries. And if it would break backwards compatibility. Haven't had time to look into that yet.
Considering the comment from @tsteur here: https://github.com/matomo-org/matomo/issues/18360#issuecomment-975820840
Mostly just core DB updates I would guess, but IDK right now.
Although don't think it's related to why the build failed: https://app.travis-ci.com/github/matomo-org/matomo/jobs/549521319#L1078
I would need to run the tests locally first.

Powered by GitHub Issue Mirror