Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to distinguish between MySQL and MariaDB (also in installation) #18371

Draft
wants to merge 2 commits into
base: 5.x-dev
Choose a base branch
from
Draft

Allow to distinguish between MySQL and MariaDB (also in installation) #18371

wants to merge 2 commits into from

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 24, 2021

Description:

This is a small draft how to solve issues that might occur in MariaDb only.
I've only spent a couple of minutes to do the changes, so I'm not even sure if it would even fully work.

I currently don't have time to finish this PR or even test if everything works as expected.
If someone has some time, feel free to pick it up.

When finished this aims to fix #18360

Review

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Nov 24, 2021
@sgiehl sgiehl mentioned this pull request Nov 24, 2021
Open
@sgiehl sgiehl added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Nov 24, 2021
@jorgeuos
Copy link

I'm curios though if there's other functionality that looks for SELECT in their queries. And if it would break backwards compatibility. Haven't had time to look into that yet.
Considering the comment from @tsteur here: #18360 (comment)
Mostly just core DB updates I would guess, but IDK right now.
Although don't think it's related to why the build failed: https://app.travis-ci.com/github/matomo-org/matomo/jobs/549521319#L1078
I would need to run the tests locally first.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Dec 9, 2021
@sgiehl sgiehl added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Dec 9, 2021
@sgiehl sgiehl force-pushed the mariadb branch 2 times, most recently from 3f35bbe to 6146b55 Compare May 9, 2022 09:34
@sgiehl sgiehl mentioned this pull request Aug 22, 2022
Open
@sgiehl sgiehl changed the base branch from 4.x-dev to 5.x-dev March 16, 2023 08:45
@sgiehl sgiehl force-pushed the mariadb branch 2 times, most recently from 406cd40 to 2ebafe7 Compare March 16, 2023 15:05
@sgiehl @michalkleiner
apply review feedback
b26c4d4 
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner left review comments

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow configuration of max execution time when using MariaDB
3 participants
@sgiehl @jorgeuos @michalkleiner