Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Vue Build action #18369

Merged
merged 1 commit into from Nov 23, 2021
Merged

Improve Vue Build action #18369

merged 1 commit into from Nov 23, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 23, 2021

Description:

Currently when a build runs for a PR coming from a fork, the action fails.

This will change the process, so it succeeds if vue files are still up to date, or leave a PR comment if the files need to be updated:

image

Review

@sgiehl
Improve Vue Build action
aca696f 
Currently when a build runs for an PR coming from a fork, the action fails. 
This will change the process, so it succeeds if vue files are still up to date, or leave a PR comment if the files need to be updated
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Better processes Indicates an issue is about improving how we work. labels Nov 23, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Nov 23, 2021
diosmosis
diosmosis approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested but it looks good

@sgiehl sgiehl merged commit 81c7fd6 into 4.x-dev Nov 23, 2021
@sgiehl sgiehl deleted the vuebuild branch November 23, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Better processes Indicates an issue is about improving how we work. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis