New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] in site selector execute search on searchTerm change rather than keydown #18367
Conversation
…ys dont have an effect
@diosmosis this seems to work as expected. While testing I found some other issues / improvements for the site selector.
|
…site name when finished loading sites, make sure search term wasnt changed when search site request finishes
e7d3a1b
to
c94efdf
Compare
@sgiehl fixed those and one other issue I found |
@diosmosis not sure that's on my local, but when I try to run vue:build CoreHome it shows the error below. |
@peterhashair can't reproduce. Are the files there? If you clear the webpack cache is the error still there? |
@diosmosis sorry that my bad, my git was on the case insensitive. didn't pick up the |
Description:
…so special keys dont have an effect
Review