@diosmosis opened this Pull Request on November 23rd 2021 Member

Description:

…so special keys dont have an effect

Review

@sgiehl commented on November 23rd 2021 Member

@diosmosis this seems to work as expected. While testing I found some other issues / improvements for the site selector.

  • Each time a search request is sent from the site selector, it also sends a request to SitesManager.getNumWebsitesToDisplayPerPage. Guess it should be enough to only do that once on init?

  • When the search term is changed, it seems that previous requests might still be executed and result in weird behavior. You can reproduce that by pasting/typing a search term and directly clicking in the search box again (which cleans the term). The results for the search will be displayed nevertheless and the input box is hidden
@diosmosis commented on November 24th 2021 Member

@sgiehl fixed those and one other issue I found

@peterhashair commented on November 24th 2021 Contributor

@diosmosis not sure that's on my local, but when I try to run vue:build CoreHome it shows the error below.
image

@diosmosis commented on November 24th 2021 Member

@peterhashair can't reproduce. Are the files there? If you clear the webpack cache is the error still there?

@peterhashair commented on November 24th 2021 Contributor

@diosmosis sorry that my bad, my git was on the case insensitive. didn't pick up the Menudropdown to MenuDropdown change. but I test this . work as expected

This Pull Request was closed on November 24th 2021
Powered by GitHub Issue Mirror