Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] in site selector execute search on searchTerm change rather than keydown #18367

Merged
merged 8 commits into from Nov 24, 2021

Conversation

diosmosis
Copy link
Member

Description:

…so special keys dont have an effect

Review

@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Nov 23, 2021
@diosmosis diosmosis added this to the 4.7.0 milestone Nov 23, 2021
@sgiehl
Copy link
Member

sgiehl commented Nov 23, 2021

@diosmosis this seems to work as expected. While testing I found some other issues / improvements for the site selector.

  • Each time a search request is sent from the site selector, it also sends a request to SitesManager.getNumWebsitesToDisplayPerPage. Guess it should be enough to only do that once on init?

  • When the search term is changed, it seems that previous requests might still be executed and result in weird behavior. You can reproduce that by pasting/typing a search term and directly clicking in the search box again (which cleans the term). The results for the search will be displayed nevertheless and the input box is hidden

@diosmosis diosmosis changed the title [Vue] in site selectrexecute search on searchTerm change rather than keydown [Vue] in site selector execute search on searchTerm change rather than keydown Nov 23, 2021
…site name when finished loading sites, make sure search term wasnt changed when search site request finishes
@diosmosis
Copy link
Member Author

@sgiehl fixed those and one other issue I found

@peterhashair
Copy link
Contributor

@diosmosis not sure that's on my local, but when I try to run vue:build CoreHome it shows the error below.
image

@diosmosis
Copy link
Member Author

@peterhashair can't reproduce. Are the files there? If you clear the webpack cache is the error still there?

@peterhashair
Copy link
Contributor

@diosmosis sorry that my bad, my git was on the case insensitive. didn't pick up the Menudropdown to MenuDropdown change. but I test this . work as expected

@sgiehl sgiehl merged commit c73fc4b into 4.x-dev Nov 24, 2021
@sgiehl sgiehl deleted the vue-site-selector-search-fix branch November 24, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants