Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info for trusted_hosts #18365

Merged
merged 3 commits into from Nov 23, 2021
Merged

Add info for trusted_hosts #18365

merged 3 commits into from Nov 23, 2021

Conversation

Starker3
Copy link
Contributor

Some users were confused what this setting exactly does, so they were adding all possible hostnames that might be used such as tracking hostnames, etc.
This results in the wrong URLs being used for things such as Email Reports.

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

Some users were confused what this setting exactly does, so they were adding all possible hostnames that might be used such as tracking hostnames, etc.
This results in the wrong URLs being used for things such as Email Reports.
@sgiehl
Copy link
Member

sgiehl commented Nov 23, 2021

Seems the travis tests haven't been triggered for this PR. Wondering if this may be caused by the failing vue action. Will prepare some changes to the action, so it doesn't fail for PRs coming from forks.

@sgiehl sgiehl merged commit f482793 into matomo-org:4.x-dev Nov 23, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Nov 23, 2021
@sgiehl sgiehl added c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Nov 23, 2021
@Starker3 Starker3 deleted the patch-1 branch November 23, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants