Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow console logging to file if configured #18358

Merged
merged 2 commits into from Nov 22, 2021
Merged

Allow console logging to file if configured #18358

merged 2 commits into from Nov 22, 2021

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Nov 22, 2021

Description:

Fixes #17053

Adds file logging for console output if the file log handler is configured

Review

@bx80 bx80 added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Easier debugging For issues that make troubleshooting issues for developers easier. labels Nov 22, 2021
@bx80 bx80 added this to the 4.7.0 milestone Nov 22, 2021
@bx80 bx80 self-assigned this Nov 22, 2021
sgiehl
sgiehl approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@sgiehl sgiehl merged commit 1041c4d into 4.x-dev Nov 22, 2021
@sgiehl sgiehl deleted the m-17053-console-file-log branch November 22, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@bx80 bx80

Labels
Easier debugging For issues that make troubleshooting issues for developers easier. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

Logging messages from console are not getting logged anywhere
2 participants
@bx80 @sgiehl