Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log archiving query timeouts #18357

Merged
merged 3 commits into from Nov 23, 2021
Merged

Log archiving query timeouts #18357

merged 3 commits into from Nov 23, 2021

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Nov 22, 2021

Description:

Fixes #18025

Added an exception handler to the archiving db adapter which will catch any exceptions thrown because of the max_execution_time hint and log the exception and query details.

Review

@bx80 bx80 added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Easier debugging For issues that make troubleshooting issues for developers easier. labels Nov 22, 2021
@bx80 bx80 added this to the 4.7.0 milestone Nov 22, 2021
@bx80 bx80 self-assigned this Nov 22, 2021
@sgiehl sgiehl merged commit e162bc7 into 4.x-dev Nov 23, 2021
@sgiehl sgiehl deleted the m-18025-archiving-handle-query-timeouts branch November 23, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@bx80 bx80

Labels
Easier debugging For issues that make troubleshooting issues for developers easier. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

Max execution timeout exceptions for archiving are not handled
2 participants
@bx80 @sgiehl