Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible notice when comparing goal data #18355

Merged
merged 1 commit into from Nov 30, 2021
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 19, 2021

Description:

happened as some metrics might have been formatted twice

fixes #18261

Review

happened as some metrics might have been formatted twice
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 19, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Nov 19, 2021
@sgiehl sgiehl requested a review from a team November 26, 2021 13:48
@diosmosis
Copy link
Member

@sgiehl this makes sense 👍, but I would expect this might happen in other contexts too. Basically any context where an API call results in more API calls to the Goals.get method. Eg, pivoting might also have this problem. I suppose a generic fix is out of scope at this point.

Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for the case described in the original issue.

@justinvelluppillai justinvelluppillai merged commit 9efa63a into 4.x-dev Nov 30, 2021
@justinvelluppillai justinvelluppillai deleted the fix18261 branch November 30, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notice - A non well formed numeric value encountered in Goals API
3 participants