This PR is based off of https://github.com/matomo-org/matomo/pull/18292.
piwik-field is a recursive directive so they all had to be converted at once, so this PR is also quite large.
piwik-fielddirective to the vue Field directive. Note: the
templateFileproperty is not longer supported. If plugin developers use it in the wild, we'll have to provide a different way of extending Field.
matomo-multi-pair-fielddirective to MultiPairField.
matomo-field-arraydirective to FieldArray.
piwik-form-fielddirective to FormField. Every template that was included in the angularjs directive was converted to a new vue component used by FormField.
@diosmosis I'm currently doing a review. Might take a while as the changes are quite huge.
Looking through some of the expected UI file changes I have already seen, that the title for text
FieldArrays are not displayed for each input anymore. See https://github.com/matomo-org/matomo/commit/d343d20a429bc86b205fb9762c498df84a566896?short_path=ecaef42#diff-ecaef42b8254004961e2206553ed6b910ac38155a6fa329264534e400d068fc0
Feel free to fix that already, while I'm still reviewing the code.
@diosmosis While clicking through the UI / tests I so far spotted this issues:
I'm done for now. Couldn't find anything else while clicking around. Feel free to re-request a review once everything is fixed.
fixed a failing test. Will merge this now. @diosmosis feel free to ping me, once the PR for custom alerts is created.