invite user replace add user #18351

Description:

fixes: #13321

Add Two table column

• invite_status sent or null
• invite_at datetime

Using currently token from user_auth_token table. Resend invite will send a link to the user, clicking the link will mark the user active and land on the password setting page.

Email template:

Missing:

• UI Test
• Integration Test

Review

• [ ] Functional review done
• [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• [ ] Security review done
• [ ] Wording review done
• [ ] Code review done
• [ ] Tests were added if useful/possible
• [ ] Reviewed for breaking changes
• [ ] Developer changelog updated if needed
• [ ] Documentation added if needed
• [ ] Existing documentation updated if needed

@peterhashair I saw your questions in the email but they are removed in the comment here. I'll comment quick anyway

To addColumn to exiting database table. do I use `4.7.0-b1?

Likely yes, it depends when we merge it and whether by then maybe already a b1 has been released. Likely it will be -b1 though.

Introduce user status, currently depending on the invite_token field, just checking, do we want to introduce this field as an individual field not relied on invite_token. So it accepts pending, suspended, disabled, etc.

Not 100% sure. It really depends whether it's needed or not. It might not be needed as I think we delete a user if we withdraw the invite etc. We probably won't have a suspended. I'd say it's probably not needed, but it's hard to say without being too much into it.

Resend invites, after people send invites do we need a status said sent, and the next send can only be done after 15mins? Otherwise, it maybe adds a mail server to span?

Yes that be good 👍

@tsteur sorry to bother you, I am trying to implement integration tests, but it seems like the database missing the new field I happened to, do I need to add a install() function inside of UserManager other than 4.7.0-b1.php

@peterhashair you will also need to adjust the schema in https://github.com/matomo-org/matomo/blob/4.6.0-rc2/core/Db/Schema/Mysql.php#L47 which is used for new installs

@tsteur it seems like the tests still don't apply that database extends fixture on my local does not update the database. It's there a way I can manually run updates, I mean manually run 4.7.0-b1.php

@peterhashair you will also need to set the version number in the version class to 4.7.0-b1

Not sure if how we test the email templates on screenshot