Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] remove problematic pathspec in buildvue.yml #18342

Merged
merged 1 commit into from Nov 18, 2021
Merged

Conversation

diosmosis
Copy link
Member

Description:

Not sure why it complains about this in the workflow, it works for me just fine even if the specified files do not exist. But we can't have the metadata json file change w/o also having the .js file change so it should be fine to depend only on the *.js pathspec.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Nov 17, 2021
@diosmosis diosmosis added this to the 4.7.0 milestone Nov 17, 2021
@sgiehl sgiehl merged commit 61103e2 into 4.x-dev Nov 18, 2021
@sgiehl sgiehl deleted the vue-fix-vue-build branch November 18, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants