Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes possible notice #18340

Merged
merged 1 commit into from Nov 18, 2021
Merged

Fixes possible notice #18340

merged 1 commit into from Nov 18, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 17, 2021

Description:

fixes #18338

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 17, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Nov 17, 2021
@tsteur
Copy link
Member

tsteur commented Nov 17, 2021

@sgiehl does this mean the user changed http.blocklist.hosts as it wouldn't be expected otherwise such a notice? I wonder if in that case we would rather need to throw an exception regarding a misconfiguration?

@sgiehl
Copy link
Member Author

sgiehl commented Nov 17, 2021

That shouldn't be the problem in that case. The parsed url (where a request should be sent to) doesn't contain a host. This could have various reasons I guess. e.g. a request to file:///tmp/file, is actually valid, but won't contain a host. Not sure what url was requested in that case.

@sgiehl sgiehl merged commit ab33924 into 4.x-dev Nov 18, 2021
@sgiehl sgiehl deleted the fixnotice branch November 18, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING Undefined index: host - Matomo 4.5.0
2 participants