Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random UI should change dashboard layout when new layout is selected #18336

Merged
merged 2 commits into from Nov 17, 2021

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Nov 17, 2021

Description:

fix random UI. It seems like the dialog Icon randomly cause an issue for that screen test. Hide in the CSS, it shouldn't cause any failure.
image

Review

Peter Zhang added 2 commits November 17, 2021 16:50
fix random UI
update screenshot
@peterhashair peterhashair marked this pull request as ready for review November 17, 2021 06:01
@peterhashair peterhashair added the Needs Review PRs that need a code review label Nov 17, 2021
@sgiehl sgiehl merged commit 898726b into 4.x-dev Nov 17, 2021
@sgiehl sgiehl deleted the fix-random-ui-fails-layout branch November 17, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants