@diosmosis opened this Pull Request on November 17th 2021 Member

Description:

Found some issues after minimum supported browser testing:

  • async/await is not supported in Vue code since it would add 6kb to each UMD file (details in original vue introduction PR)
  • Feedback plugin can be disabled (due to WhiteLabel for example), so don't access it if it's not there
  • fix typo in FeedbackQuestion.adapter.ts

Review

@tsteur commented on November 17th 2021 Member

@diosmosis as we've already released an RC be great to target next_release branch instead of 4.x-dev so it makes it into the next 4.6 release (https://github.com/matomo-org/developer-documentation/pull/586/files)

@diosmosis commented on November 17th 2021 Member

@tsteur done

@diosmosis commented on November 17th 2021 Member

@peterhashair there were two issues (and a typo), the other issue was mine :+1:

This Pull Request was closed on November 17th 2021
Powered by GitHub Issue Mirror