@peterhashair opened this Pull Request on November 16th 2021 Contributor

Description:

fixes: #17944
add cache and lock to segment load, using lazy cache

Review

@peterhashair commented on November 17th 2021 Contributor

@tsteur just testing, I saw on the goal page, the same problem we have last time appears, happens here as well. each graphic called the API.getSegmentsMetadata. only happened when we have lots of goals. Not sure that can be fixed, because the cache won't carry to another request.

@tsteur commented on November 17th 2021 Member

Using lazy cache would be ideal for performance but be quite a bit of work to invalidate all the caches in the right moments which makes it very hard and a long job. I guess the idea with transient cache is that it may be an easy fix and we already make it maybe say 50% better compared to making it 90% better but a lot of work. Be good to double check if with a few segments this method is called quite often during one request.

This Pull Request was closed on November 22nd 2021
Powered by GitHub Issue Mirror