Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements for PHP 8.1 #18330

Merged
merged 5 commits into from Nov 24, 2021
Merged

Further improvements for PHP 8.1 #18330

merged 5 commits into from Nov 24, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 16, 2021

Description:

I'm still running the tests locally to identify more PHP 8.1 related issues.
I will continue to push additional commits to this PR till I'm not able to identify more (by running the tests).

refs #17686

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 16, 2021
@sgiehl
Copy link
Member Author

sgiehl commented Nov 24, 2021

This should be ready for review. Might do some more testing with PHP 8.1 another time and create further PRs if needed.

@sgiehl sgiehl marked this pull request as ready for review November 24, 2021 15:02
@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 24, 2021
@sgiehl sgiehl added this to the 4.7.0 milestone Nov 24, 2021
@sgiehl sgiehl merged commit af4d600 into 4.x-dev Nov 24, 2021
@sgiehl sgiehl deleted the php81fixes branch November 24, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants