@sgiehl opened this Pull Request on November 16th 2021 Member

Description:

We are currently still using Symfony Console (and other components) in version 2.6.
This one is quite outdated and has some issues with PHP 8.1 (deprecation warnings).

This PR will update all components to the last available version 5.3.x.

So far there were two issues I have identified after the update:

  • The monolog class ConsoleFormatter does not longer have multiple constructor parameters, but takes an option array instead. This was adjusted in plugins/Monolog/config/cli.php

  • The execute method of a console command is now kind of forced to return an integer. Before that was kind of expected, but all other values were silently treated as 0. I have adjusted our command class, so it will catch and log that error and return 0 in that case. That way commands that may not yet be adjusted won't fail. I have nevertheless changed all commands in core here and already created PRs for the submodule plugins.

Review

Powered by GitHub Issue Mirror