Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update script that might cause problems #18325

Merged
merged 1 commit into from Nov 16, 2021
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 16, 2021

Description:

Was wondering a few times lately why the file /plugins/VisitFrequency/Archiver.php was removed locally after running tests.
Seems the reason is, that some updater tests are trying to update from a very old version, causing all update scripts to be executed.

I guess the same might actually happen if someone tries updating from Piwik before 2.2 to Matomo after 4.1.2. The update would first create the Archiver file and the update script would then remove it again when it is executed.
Should be better to remove that one.

ping @diosmosis You had removed that file in one of your PRs by accident as well. guess this is the reason.

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 16, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Nov 16, 2021
@sgiehl sgiehl requested a review from tsteur November 16, 2021 08:22
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . could put this into next_release branch but not too important

@tsteur
Copy link
Member

tsteur commented Nov 16, 2021

ACtually better we merge this into 4.x-dev as only few users would upgrade some such an old version anyway, and the next update would bring the file again.

@tsteur tsteur merged commit 810077e into 4.x-dev Nov 16, 2021
@tsteur tsteur deleted the fixupdateissue branch November 16, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants