Sort segment static lists by usage #18321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peratingSystemName
bx80
added
the
not-in-changelog
sgiehl
reviewed
Nov 16, 2021
sgiehl
requested changes
Nov 17, 2021
|
Looks good and works as expected. |
|
I've added a property to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #15620
API calls to suggested values for segments that are static lists (eg. countries) will now be returned sorted by the most used values first. This should mitigate the issue where suggested value lists do not contain the most frequently used values.
For example, the getSuggestedValuesForSegment list for countryName will now return a list of country names with the countries that have the most visits at the top rather than an alphabetical list potentially containing countries that have no visits or missing countries with many visits but names towards the end of the alphabet.
This has been applied to segments: countryName, browserName and operatingSystemName
Review