Update Feedback Question banner #18308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 15, 2021 10:17
update table random UI
update icon list
update screen shots
hide feedback on mobile
update feed back
peterhashair
changed the title
peterhashair
changed the title
update feedback Test
21 tasks
peterhashair
added
not-in-changelog
added 3 commits
November 15, 2021 16:22
update UI screenshot Test
update UI tests
update screenshots
sgiehl
reviewed
Nov 15, 2021
Comment on lines
-124
to
+132
| if ($nextReminderDate === false || $nextReminderDate <= 0) { | ||
|
|
||
| // if user is created more than 6 month ago, set reminder to today and show banner | ||
| $userCreatedDate = Piwik::getCurrentUserCreationData(); | ||
| if (!empty($userCreatedDate) && Date::factory($userCreatedDate)->addMonth(6)->getTimestamp() < $now) { | ||
| $nextReminder = Date::now()->getStartOfDay()->subDay(1)->toString('Y-m-d'); | ||
| $feedbackReminder->setUserOption($nextReminder); | ||
| return true; | ||
| } | ||
| if ($nextReminderDate === false) { |
There was a problem hiding this comment.
This actually makes it worse, as everyone will now get notified 6 months after the update. I will merge this PR now nevertheless, so the other fixes are in 4.x-dev. Will create a PR to improve those checks myself later
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update feedback Question Banner, Fix random UI failed for UIIntegrationTest I think this is related to #18124, update selection.json missing heart icon #18262.
Also, follow up on request here #18251 (comment)
Review