Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic Check for private directories does not work when Matomo is installed in a directory #18305

Closed
tsteur opened this issue Nov 14, 2021 · 1 comment
Closed

Diagnostic Check for private directories does not work when Matomo is installed in a directory #18305

tsteur opened this issue Nov 14, 2021 · 1 comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone
4.7.0

Comments

@tsteur
Copy link
Member

tsteur commented Nov 14, 2021 •
edited

see #18132 (comment)

My problem is that the System-Check tries https://mydomain.com/config/config.ini.php instead of https://mydomain.com/matomo/config/config.ini.php (Issue #17945).

I checked and it's using SettingsPiwik::getPiwikUrl indeed. Maybe something like Url::getCurrentUrlWithoutQueryString() should be used.

Do I see this right that we might be using SettingsPiwik::getPiwikUrl wrong also in quite a lot of other places @sgiehl ? Maybe we need to adjust the method to also consider the path potentially? But then we might also need a getPiwikHost method where it only returns the host (eg when we generate the option for the console --matomo-domain=$HOST).

Edit: created #18306

This issue is only for fixing the diagnostic check
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Nov 14, 2021
@tsteur tsteur added this to the 4.7.0 milestone Nov 14, 2021
This was referenced Nov 14, 2021
Closed
Closed
@tsteur tsteur added duplicate For issues that already existed in our issue tracker and were reported previously. and removed Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Nov 14, 2021
@tsteur tsteur closed this as completed Nov 14, 2021
@tsteur
Copy link
Member Author

tsteur commented Nov 14, 2021

actually let's use the original issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
4.7.0
Development

No branches or pull requests
1 participant
@tsteur