Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates device detector to new major version #18299

Merged
merged 2 commits into from Nov 15, 2021
Merged

Updates device detector to new major version #18299

merged 2 commits into from Nov 15, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 12, 2021

Description:

see title

Review

@sgiehl sgiehl added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Nov 12, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Nov 12, 2021
@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 12, 2021
@sgiehl sgiehl marked this pull request as ready for review November 12, 2021 08:40
justinvelluppillai
justinvelluppillai approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, test failures unrelated. I'm not sure if anything special to test locally?

@sgiehl
Copy link
Member Author

sgiehl commented Nov 15, 2021

@justinvelluppillai there shouldn't be any need for local testing in that case as either some more system tests or UI tests might fail if the version of device detector would cause issues.

@sgiehl sgiehl merged commit 56ee0e3 into 4.x-dev Nov 15, 2021
@sgiehl sgiehl deleted the updatedd branch November 15, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @justinvelluppillai